jolshan commented on code in PR #23831:
URL: https://github.com/apache/kafka/pull/23831#discussion_r4327549531
##########
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionCoordinatorTest.scala:
##########
@@ -858,12 +872,124 @@ class TransactionCoordinatorTest {
coordinator.handleEndTransaction(transactionalId, producerId,
epoch.toShort, TransactionResult.COMMIT, clientTransactionVersion,
endTxnCallback)
if (isRetry) {
assertEquals(Errors.PRODUCER_FENCED, error)
+ verifyNoAppend()
} else {
- assertEquals(Errors.INVALID_TXN_STATE, error)
+ verifyEmptyCommitAppended()
}
verify(transactionManager).getTransactionState(ArgumentMatchers.eq(transactionalId))
}
+ @ParameterizedTest
+ @EnumSource(value = classOf[TransactionState], names = Array("EMPTY",
"COMPLETE_COMMIT", "COMPLETE_ABORT"))
+ def shouldCompleteEmptyCommitWithoutMarkersInV2(state: TransactionState):
Unit = {
+ val txnMetadata = new TransactionMetadata(transactionalId, producerId,
producerId, RecordBatch.NO_PRODUCER_ID,
+ producerEpoch, (producerEpoch - 1).toShort, 1, state, util.Set.of, 0,
time.milliseconds(), TV_2)
+
when(transactionManager.getTransactionState(ArgumentMatchers.eq(transactionalId)))
+ .thenReturn(Right(Some(new
CoordinatorEpochAndTxnMetadata(coordinatorEpoch, txnMetadata))))
+ when(transactionManager.appendTransactionToLog(
+ ArgumentMatchers.eq(transactionalId),
+ ArgumentMatchers.eq(coordinatorEpoch),
+ capturedTxnTransitMetadata.capture(),
+ capturedErrorsCallback.capture(),
+ any(),
+ any())
+ ).thenAnswer(_ => {
+ txnMetadata.completeTransitionTo(capturedTxnTransitMetadata.getValue)
+ capturedErrorsCallback.getValue.apply(Errors.NONE)
+ })
+
+ coordinator.handleEndTransaction(transactionalId, producerId,
producerEpoch, TransactionResult.COMMIT, TV_2, endTxnCallback)
+
+ assertEquals(Errors.NONE, error)
+ assertEquals(producerId, newProducerId)
+ assertEquals(producerEpoch + 1, newEpoch)
+ assertEquals(TransactionState.PREPARE_COMMIT, txnMetadata.state)
+ assertTrue(txnMetadata.topicPartitions.isEmpty)
+ verify(transactionMarkerChannelManager).addTxnMarkersToSend(
Review Comment:
Interesting. It's not totally clear this is checking the no partitions case,
but maybe that's ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
