chia7712 commented on code in PR #23815:
URL: https://github.com/apache/kafka/pull/23815#discussion_r4298052661
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java:
##########
@@ -162,6 +162,11 @@ private void clear() {
this.bufferedRecords.clear();
}
+ // buffered records at or after bufferedLimitIndex are beyond the
limit and cannot be applied yet
+ private boolean hasBufferedRecordsBeyondLimit() {
+ return bufferedRecords.size() > bufferedLimitIndex;
Review Comment:
The bufferedLimitIndex needs to be kept updated, otherwise the paused
standby will be stuck forever, right? If so, we should add a comment to
maybeUpdateLimitOffsetsForStandbyChangelogs and a test to guard against a
silent hang.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]