unknowntpo commented on code in PR #23815:
URL: https://github.com/apache/kafka/pull/23815#discussion_r4304124048
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java:
##########
@@ -162,6 +162,11 @@ private void clear() {
this.bufferedRecords.clear();
}
+ // buffered records at or after bufferedLimitIndex are beyond the
limit and cannot be applied yet
+ private boolean hasBufferedRecordsBeyondLimit() {
+ return bufferedRecords.size() > bufferedLimitIndex;
Review Comment:
Yes, right. A paused partition is resumed only after
maybeUpdateLimitOffsetsForStandbyChangelogs moves bufferedLimitIndex past its
buffered records, so if that update stopped, the standby would stay paused
forever. I added a comment there in 91c6095c1f.
For the test,
shouldResumeSourceChangelogStandbyOnceLimitPassesBufferedRecords already guards
against this hang: if the update skips paused partitions, it fails with
expected: <15> but was: <0>. I added a comment to the test to make that clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]