sunm2n commented on PR #23874: URL: https://github.com/apache/kafka/pull/23874#issuecomment-6281325353
@AndrewJSchofield Could you take a look when you have a chance? This adds a test for the topic-removal path in the homogeneous share group assignor, following your work on KAFKA-19362. CI is awaiting approval. Could you also add the ci-approved label to allow it to run? Testing: - All 17 tests in SimpleAssignorTest pass. - The new test passed in 20 repeated runs with randomly generated topic IDs. - Removing `newMemberAssignment.remove(topicId)` from `revokeUnassignablePartitions` causes the new test to fail because topic 2 remains assigned. - JaCoCo confirms that the topic-removal branch is exercised by the new test; it was not exercised by the existing assignor tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
