apoorvmittal10 commented on code in PR #23911:
URL: https://github.com/apache/kafka/pull/23911#discussion_r4349489674
##########
core/src/test/java/kafka/server/share/DelayedShareFetchTest.java:
##########
@@ -965,7 +961,6 @@ public void
testTryCompleteReleasesLocksWhenAsyncReadImmediatelyThrows() {
SharePartition sp0 = mock(SharePartition.class);
when(sp0.canAcquireRecords()).thenReturn(true);
// Empty fetch offset metadata forces maybeReadFromLog to actually
read from the log.
Review Comment:
Missed it, done.
##########
core/src/test/java/kafka/server/share/DelayedShareFetchTest.java:
##########
@@ -1497,9 +1484,6 @@ public void
testRemoteStorageFetchTryCompleteReturnsFalse() {
when(sp2.nextFetchOffset()).thenReturn(30L);
// Fetch offset matches with the cached entry for sp0 but not for sp1
and sp2. Hence, a replica manager fetch will happen for sp1 and sp2.
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
