apoorvmittal10 commented on code in PR #23911:
URL: https://github.com/apache/kafka/pull/23911#discussion_r4354451539
##########
core/src/test/java/kafka/server/share/DelayedShareFetchTest.java:
##########
@@ -222,12 +221,9 @@ public void
testTryCompleteWhenMinBytesNotSatisfiedOnFirstFetch() {
// We are testing the case when the share partition is getting fetched
for the first time, so for the first time
// the fetchOffsetMetadata will return empty. Post the first
readFromLog call, the fetchOffsetMetadata will be
Review Comment:
Done.
##########
core/src/test/java/kafka/server/share/DelayedShareFetchTest.java:
##########
@@ -327,6 +322,8 @@ public void
testTryCompleteWhenMinBytesNotSatisfiedOnSubsequentFetch() {
.withFetchId(fetchId)
.build());
+ // The share partition has been fetched before, hence the fetch offset
metadata is already cached.
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
