frankvicky commented on code in PR #23109:
URL: https://github.com/apache/kafka/pull/23109#discussion_r4360516579
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -2433,7 +2433,7 @@ boolean processBackgroundEvents(boolean
skipAssignmentEvents) {
* As an example, take {@link #unsubscribe()}. To start unsubscribing, the
application thread enqueues an
* {@link UnsubscribeEvent} on the application event queue. That event
will eventually trigger the
* rebalancing logic in the background thread. Critically, as part of this
rebalancing work, the
- * {@link ConsumerRebalanceListener#onPartitionsRevoked(Collection)}
callback needs to be invoked for any
+ * {@link RebalanceListener#onPartitionsRevoked(Collection,
RebalanceConsumer)} callback needs to be invoked for any
Review Comment:
need to import org.apache.kafka.clients.consumer.RebalanceConsumer;
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java:
##########
@@ -441,9 +441,9 @@ private CompletableFuture<Void>
enqueuePartitionsAssignedEvent(Set<TopicPartitio
}
/**
- * Signals that a {@link ConsumerRebalanceListener} callback has
completed. This is invoked when the
+ * Signals that a {@link RebalanceListener} callback has completed. This
is invoked when the
* application thread has completed the callback and has submitted a
- * {@link ConsumerRebalanceListenerCallbackCompletedEvent} to the network
I/O thread. At this point, we
+ * {@link RebalanceListenerCallbackCompletedEvent} to the network I/O
thread. At this point, we
Review Comment:
Do we have this event?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
