adikou commented on code in PR #23109:
URL: https://github.com/apache/kafka/pull/23109#discussion_r4361026749
##########
clients/src/main/java/org/apache/kafka/clients/consumer/StickyAssignor.java:
##########
@@ -145,15 +145,15 @@
* clarifies this point:
* <pre>
* {@code
- * class TheNewRebalanceListener implements ConsumerRebalanceListener {
+ * class TheNewRebalanceListener implements RebalanceListener {
* Collection<TopicPartition> lastAssignment = Collections.emptyList();
*
- * void onPartitionsRevoked(Collection<TopicPartition> partitions) {
+ * void onPartitionsRevoked(Collection<TopicPartition> partitions,
RebalanceConsumer consumer) {
* for (TopicPartition partition: partitions)
* commitOffsets(partition);
Review Comment:
Done, both examples call consumer.commitSync()
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ClassicKafkaConsumer.java:
##########
@@ -566,7 +566,7 @@ public void subscribe(SubscriptionPattern pattern) {
* the max metadata age, the consumer will refresh metadata more often and
check for matching topics.
* <p>
* See {@link #subscribe(Collection, ConsumerRebalanceListener)} for
details on the
- * use of the {@link ConsumerRebalanceListener}. Generally rebalances are
triggered when there
+ * use of the {@link RebalanceListener}. Generally rebalances are
triggered when there
Review Comment:
done, points to `RebalanceListener`
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -2433,7 +2433,7 @@ boolean processBackgroundEvents(boolean
skipAssignmentEvents) {
* As an example, take {@link #unsubscribe()}. To start unsubscribing, the
application thread enqueues an
* {@link UnsubscribeEvent} on the application event queue. That event
will eventually trigger the
* rebalancing logic in the background thread. Critically, as part of this
rebalancing work, the
- * {@link ConsumerRebalanceListener#onPartitionsRevoked(Collection)}
callback needs to be invoked for any
+ * {@link RebalanceListener#onPartitionsRevoked(Collection,
RebalanceConsumer)} callback needs to be invoked for any
Review Comment:
Added. I wonder if we should break the build if javadoc fails to build with
broken link, nothing is breaking the CI right now.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java:
##########
@@ -441,9 +441,9 @@ private CompletableFuture<Void>
enqueuePartitionsAssignedEvent(Set<TopicPartitio
}
/**
- * Signals that a {@link ConsumerRebalanceListener} callback has
completed. This is invoked when the
+ * Signals that a {@link RebalanceListener} callback has completed. This
is invoked when the
* application thread has completed the callback and has submitted a
- * {@link ConsumerRebalanceListenerCallbackCompletedEvent} to the network
I/O thread. At this point, we
+ * {@link RebalanceListenerCallbackCompletedEvent} to the network I/O
thread. At this point, we
Review Comment:
Good catch, that class doesn't exist. The link points back at
`ConsumerRebalanceListenerCallbackCompletedEvent`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
