ryanwaha commented on PR #23945: URL: https://github.com/apache/kafka/pull/23945#issuecomment-6381534356
### Verification Ran `.github/scripts/junit.py` from trunk and from this branch against the JUnit XML artifacts of a recent trunk CI run: https://github.com/apache/kafka/actions/runs/39984672142 | artifact | quarantined rows (before → after) | result | |---|---|---| | `junit-xml-25-flaky-nonew` | 19 → 19 | sorted; same rows; rest of the summary unchanged | | `junit-xml-17-flaky-nonew` | 19 → 19 | sorted; same rows; rest of the summary unchanged | | `junit-xml-25-noflaky-new` (control) | 0 → 0 | output byte-identical | Without this change the order follows the filesystem enumeration of `glob()`, so it isn't even stable: for the same XML files, the CI job summary of that run lists `UserClientIdQuotaTest` first, while a local run lists `QuorumControllerTest` first. With this change both produce the same sorted table. <details><summary>Quarantined table, Java 25: before vs after</summary> | # | before (trunk, local run) | after (this PR) | |---|---|---| | 1 | QuorumControllerTest > testMinIsrUpdateWithElr() | AclControlManagerTest > testDeleteExceedsMaxRecords() | | 2 | AclControlManagerTest > testDeleteExceedsMaxRecords() | ClientIdQuotaTest > testThrottledProducerConsumer(String).groupProtocol=classic | | 3 | ConsumerBounceTest > testClassicClose [1] … | ClientIdQuotaTest > testThrottledProducerConsumer(String).groupProtocol=consumer | | 4 | StickyAssignorTest > testLargeAssignmentAndGroupWithNonEqualSubscription(boolean).hasConsumerRack = false | ConsumerBounceTest > testClassicClose [1] … | | 5 | StickyAssignorTest > testLargeAssignmentAndGroupWithNonEqualSubscription(boolean).hasConsumerRack = true | CooperativeStickyAssignorTest > testLargeAssignmentAndGroupWithNonEqualSubscription(boolean).hasConsumerRack = false | | 6 | StickyAssignorTest > testLargeAssignmentAndGroupWithUniformSubscription(boolean).hasConsumerRack = false | CooperativeStickyAssignorTest > testLargeAssignmentAndGroupWithNonEqualSubscription(boolean).hasConsumerRack = true | | 7 | StickyAssignorTest > testLargeAssignmentAndGroupWithUniformSubscription(boolean).hasConsumerRack = true | OffsetsApiIntegrationTest > testAlterSinkConnectorOffsetsDifferentKafkaClusterTargeted() | | 8 | Tls13SelectorTest > testCloseOldestConnection() | OffsetsApiIntegrationTest > testGetSinkConnectorOffsetsDifferentKafkaClusterTargeted() | | 9 | CooperativeStickyAssignorTest > testLargeAssignmentAndGroupWithNonEqualSubscription(boolean).hasConsumerRack = false | OffsetsApiIntegrationTest > testResetSinkConnectorOffsetsOverriddenConsumerGroupId() | | 10 | CooperativeStickyAssignorTest > testLargeAssignmentAndGroupWithNonEqualSubscription(boolean).hasConsumerRack = true | QuorumControllerTest > testMinIsrUpdateWithElr() | | 11 | OffsetsApiIntegrationTest > testAlterSinkConnectorOffsetsDifferentKafkaClusterTargeted() | StickyAssignorTest > testLargeAssignmentAndGroupWithNonEqualSubscription(boolean).hasConsumerRack = false | | 12 | OffsetsApiIntegrationTest > testResetSinkConnectorOffsetsOverriddenConsumerGroupId() | StickyAssignorTest > testLargeAssignmentAndGroupWithNonEqualSubscription(boolean).hasConsumerRack = true | | 13 | OffsetsApiIntegrationTest > testGetSinkConnectorOffsetsDifferentKafkaClusterTargeted() | StickyAssignorTest > testLargeAssignmentAndGroupWithUniformSubscription(boolean).hasConsumerRack = false | | 14 | ClientIdQuotaTest > testThrottledProducerConsumer(String).groupProtocol=classic | StickyAssignorTest > testLargeAssignmentAndGroupWithUniformSubscription(boolean).hasConsumerRack = true | | 15 | ClientIdQuotaTest > testThrottledProducerConsumer(String).groupProtocol=consumer | Tls13SelectorTest > testCloseOldestConnection() | | 16 | UserClientIdQuotaTest > testThrottledProducerConsumer(String).groupProtocol=classic | UserClientIdQuotaTest > testThrottledProducerConsumer(String).groupProtocol=classic | | 17 | UserClientIdQuotaTest > testThrottledProducerConsumer(String).groupProtocol=consumer | UserClientIdQuotaTest > testThrottledProducerConsumer(String).groupProtocol=consumer | | 18 | UserQuotaTest > testThrottledProducerConsumer(String).groupProtocol=classic | UserQuotaTest > testThrottledProducerConsumer(String).groupProtocol=classic | | 19 | UserQuotaTest > testThrottledProducerConsumer(String).groupProtocol=consumer | UserQuotaTest > testThrottledProducerConsumer(String).groupProtocol=consumer | `[1] …` = `Type=Raft-Isolated, MetadataVersion=4.5-IV0, …` (shortened). Java 17 gives the same result. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
