lytt925 commented on code in PR #23699:
URL: https://github.com/apache/kafka/pull/23699#discussion_r4366477198
##########
test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/ClusterInstance.java:
##########
@@ -329,26 +330,31 @@ default void waitTopicDeletion(String topic) throws
InterruptedException {
), "Failed to hard-delete the delete directory");
}
- default void createTopic(String topicName, int partitions, short replicas)
throws InterruptedException {
+ default void createTopic(String topicName, int partitions, short replicas)
{
createTopic(topicName, partitions, replicas, Map.of());
}
- default void createTopic(String topicName, int partitions, short replicas,
Map<String, String> props) throws InterruptedException {
- try (Admin admin = admin()) {
- admin.createTopics(List.of(new NewTopic(topicName, partitions,
replicas).configs(props)));
- waitTopicCreation(topicName, partitions);
- }
+ default void createTopic(String topicName, int partitions, short replicas,
Map<String, String> props) {
+ createTopicAndWait(new NewTopic(topicName, partitions,
replicas).configs(props), partitions);
}
- default void createTopicWithAssignment(String topicName, Map<Integer,
List<Integer>> replicaAssignment) throws InterruptedException {
+ default void createTopicWithAssignment(String topicName, Map<Integer,
List<Integer>> replicaAssignment) {
createTopicWithAssignment(topicName, replicaAssignment, Map.of());
}
- default void createTopicWithAssignment(String topicName, Map<Integer,
List<Integer>> replicaAssignment, Map<String, String> props) throws
InterruptedException {
+ default void createTopicWithAssignment(String topicName, Map<Integer,
List<Integer>> replicaAssignment, Map<String, String> props) {
+ createTopicAndWait(new NewTopic(topicName,
replicaAssignment).configs(props), replicaAssignment.size());
+ }
+
+ private void createTopicAndWait(NewTopic newTopic, int partitions) {
try (Admin admin = admin()) {
- admin.createTopics(List.of(new NewTopic(topicName,
replicaAssignment).configs(props)));
- int partitions = replicaAssignment.size();
- waitTopicCreation(topicName, partitions);
+ admin.createTopics(List.of(newTopic)).all().get();
+ waitTopicCreation(newTopic.name(), partitions);
+ } catch (InterruptedException e) {
+ throw new InterruptException(e);
+ } catch (ExecutionException e) {
+ if (e.getCause() instanceof RuntimeException re) throw re;
Review Comment:
Thanks! updated in
[93160e7](https://github.com/apache/kafka/pull/23699/commits/93160e714fb091f9f1d0542159ca226200bb1122).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
