m1a2st commented on code in PR #23699:
URL: https://github.com/apache/kafka/pull/23699#discussion_r4190728082
##########
server/src/test/java/org/apache/kafka/server/CordonedLogDirsIntegrationTest.java:
##########
@@ -494,11 +494,11 @@ private void setCordonedLogDirs(Admin admin, List<String>
logDirs, ConfigResourc
}, 10_000, "Unable to set the " + CORDONED_LOG_DIRS_CONFIG + "
configuration on " + cr + ".");
}
- private void createTopic(String name) throws InterruptedException {
+ private void createTopic(String name) {
createTopic(name, (short) clusterInstance.brokers().size());
}
- private void createTopic(String name, short replicationFactor) throws
InterruptedException {
+ private void createTopic(String name, short replicationFactor) {
clusterInstance.createTopic(name, 1, replicationFactor);
}
Review Comment:
We can inline this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
