muralibasani commented on code in PR #22458:
URL: https://github.com/apache/kafka/pull/22458#discussion_r4383067148
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -1215,8 +1226,32 @@ private void subscribeConsumer() {
}
}
- public void resizeCache(final long size) {
- cacheResizeSize.set(size);
+ public void resizeCacheAndBufferMemory(final long cacheSize, final long
maxBufferSize) {
+ cacheResizeSize.set(cacheSize);
+ maxBufferSizeInBytes.set(maxBufferSize);
+ }
+
+ // Drop revoked partitions so we never later resume one now owned by
another path (reset/rebalance).
+ void removePartitionsFromBufferOverflowTracking(final
Collection<TopicPartition> revokedPartitions) {
+ partitionsPausedForBufferOverflow.removeAll(revokedPartitions);
+ }
+
+ private void maybeResumePartitionsPausedForBufferOverflow() {
Review Comment:
Good one, thanks. Fixed. toResume is now also intersected with a new
TaskManager#activeInitializedInputPartitions() in addition to the assignment
filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
