muralibasani commented on PR #22458: URL: https://github.com/apache/kafka/pull/22458#issuecomment-6428595779
> Thanks for the update, the round-2 items are all addressed and the touched test classes pass locally on `45b20278b8`. > > Two remaining issues I think are blocking (see inline): the bytes-guard resume on the `closeDirtyAndRevive` path can crash the thread, and with only the deprecated config set the legacy resume defeats the bytes cap every iteration. > > Separately, given this feature was reverted in 2022 for a performance regression with the same pause-all-non-empty algorithm, could you post a simple throughput comparison against trunk (default config, and a cap small enough to trigger pausing) before we merge? Also please retarget the deprecation/upgrade notes to 4.5 since 4.4 has branched. Thankyou @frankvicky for the thorough review. Both blocking issues are addressed including other comments. Ptal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
