lucasbru commented on code in PR #23944:
URL: https://github.com/apache/kafka/pull/23944#discussion_r4388276208
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/StreamsGroupWarmupTaskIntegrationTest.java:
##########
@@ -172,7 +172,7 @@ public void onBatchRestored(final TopicPartition
topicPartition,
final long batchEndOffset,
final long numRestored) {
// this test's topology/scale-out shape guarantees exactly
one task ever warms up on
- // kafkaStreams1, so a plain set is sufficient (see
findStandbyTaskId's own "at most one" check).
+ // kafkaStreams1, so a plain set is sufficient (asserted
below on warmupChangelogs).
Review Comment:
The pointer to warmupChangelogs doesn't really justify this. The restore
listener never sees the warm-up (as the comment further down says), so the
warm-up count says nothing about how often onBatchRestored fires. What we
actually expect is that it never fires (the assertEquals(-1L, ...) at the end).
Maybe just say that here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
