muralibasani commented on code in PR #23986:
URL: https://github.com/apache/kafka/pull/23986#discussion_r4393835196
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -126,7 +126,10 @@ public class ProducerConfig extends AbstractConfig {
/** <code>partitioner.rack.aware</code> */
public static final String PARTITIONER_RACK_AWARE_CONFIG =
"partitioner.rack.aware";
- private static final String PARTITIONER_RACK_AWARE_DOC = "Controls whether
the default partitioner is rack-aware. This has no effect when a custom
partitioner is used.";
+ private static final String PARTITIONER_RACK_AWARE_DOC = "Controls whether
the default partitioner is rack-aware. "
+ + "When enabled, the sticky partition is chosen from partitions
whose leader is in the same rack as <code>" +
CommonClientConfigs.CLIENT_RACK_CONFIG
Review Comment:
> When enabled, the sticky partition is chosen from partitions whose leader
is in the same rack
But BuiltInPartitioner actually falls back to all available partitions when
none are in the client's rack based on partitioner.class doc. So looks like
there is a contradiction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
