muralibasani commented on code in PR #23986:
URL: https://github.com/apache/kafka/pull/23986#discussion_r4393849598
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -126,7 +126,10 @@ public class ProducerConfig extends AbstractConfig {
/** <code>partitioner.rack.aware</code> */
public static final String PARTITIONER_RACK_AWARE_CONFIG =
"partitioner.rack.aware";
- private static final String PARTITIONER_RACK_AWARE_DOC = "Controls whether
the default partitioner is rack-aware. This has no effect when a custom
partitioner is used.";
+ private static final String PARTITIONER_RACK_AWARE_DOC = "Controls whether
the default partitioner is rack-aware. "
+ + "When enabled, the sticky partition is chosen from partitions
whose leader is in the same rack as <code>" +
CommonClientConfigs.CLIENT_RACK_CONFIG
+ + "</code>, which must be set. It only applies to records without
a key, or to all records when <code>" + PARTITIONER_IGNORE_KEYS_CONFIG +
"=true</code>. "
Review Comment:
> which must be set
It's vague. May be "the producer fails at construction with a
ConfigException if client.rack is missing." ?
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -126,7 +126,10 @@ public class ProducerConfig extends AbstractConfig {
/** <code>partitioner.rack.aware</code> */
public static final String PARTITIONER_RACK_AWARE_CONFIG =
"partitioner.rack.aware";
- private static final String PARTITIONER_RACK_AWARE_DOC = "Controls whether
the default partitioner is rack-aware. This has no effect when a custom
partitioner is used.";
+ private static final String PARTITIONER_RACK_AWARE_DOC = "Controls whether
the default partitioner is rack-aware. "
+ + "When enabled, the sticky partition is chosen from partitions
whose leader is in the same rack as <code>" +
CommonClientConfigs.CLIENT_RACK_CONFIG
+ + "</code>, which must be set. It only applies to records without
a key, or to all records when <code>" + PARTITIONER_IGNORE_KEYS_CONFIG +
"=true</code>. "
Review Comment:
> which must be set
It's a bit vague. May be "the producer fails at construction with a
ConfigException if client.rack is missing." ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
