mjsax commented on code in PR #23987:
URL: https://github.com/apache/kafka/pull/23987#discussion_r4414961530
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/StreamsGroupWarmupTaskLifecycleIntegrationTest.java:
##########
@@ -290,8 +321,6 @@ && targetActiveTasks(group, c).equals(tasksOfLeaver)
&& activeTasks(group, c).equals(tasksOfLeaver)
&& activeTasks(group, owner).equals(tasksOfOwner)
&& totalWarmupTasks(group) == 0);
- // Observed through the standby update listener rather than the thread
metadata, which a stream thread only
- // refreshes once all its active tasks are restored -- and c's gate
holds back the restore of its new tasks.
TestUtils.waitForCondition(
Review Comment:
I don't think the comment is really helpful? It's more of an "historic /
changelog" comment (typical for Claude to add) -- guess it was added during a
PR update? -- The code itself make its clear that we are using the listener.
Why would we explain a list of "other options" we didn't use? Seems a little
silly to me.
If you think the comment is indeed helpful, happy to keep, but for this
case, we should add a similar comment elsewhere, where we have the same pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
