mjsax commented on code in PR #23987:
URL: https://github.com/apache/kafka/pull/23987#discussion_r4418694813
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java:
##########
@@ -183,6 +183,8 @@ public StreamsGroupHeartbeatRequestData buildRequestData() {
if (assignmentChanged
|| taskOffsetIntervalPassed(now)
||
hasAtLeastOneHotWarmupTask(reconciledAssignment.warmupTasks(), taskOffsetSum,
taskEndOffsetSum)
+ ||
hasAtLeastOneHotRestoringActiveTask(reconciledAssignment.activeTasks(),
taskOffsetSum, taskEndOffsetSum)
Review Comment:
Will look into this as a follow up. Seems to be more like a refactoring, so
might be good enough to only have in `trunk` (no need to back-port for `4.4.1`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
