mjsax commented on code in PR #23978:
URL: https://github.com/apache/kafka/pull/23978#discussion_r4419217541
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -8810,20 +8820,20 @@ private CoordinatorResult<HeartbeatResponseData,
CoordinatorRecord> classicGroup
* @return The matching {@link StreamsGroupMember}.
* @throws GroupIdNotFoundException if no streams group with this id
exists.
* @throws UnknownMemberIdException if the member is not currently in the
group.
- * @throws InvalidRequestException if {@code pushedEpoch} does not match
the group's
- * current topology epoch.
+ * @throws StreamsInvalidTopologyEpochException if {@code pushedEpoch}
does not match the
+ * group's current topology
epoch.
*/
public StreamsGroupMember validateStreamsGroupTopologyDescriptionUpdate(
String groupId,
String memberId,
int pushedEpoch,
long committedOffset
- ) throws GroupIdNotFoundException, UnknownMemberIdException,
InvalidRequestException {
+ ) throws GroupIdNotFoundException, UnknownMemberIdException,
StreamsInvalidTopologyEpochException {
StreamsGroup group = streamsGroup(groupId, committedOffset);
StreamsGroupMember member = group.getMemberOrThrow(memberId,
committedOffset);
int currentEpoch = group.currentTopologyEpoch();
if (pushedEpoch != currentEpoch) {
Review Comment:
Find with me for now. -- Overall, it seems we might want to rethink the
relationship of heartbeat-topology and topology-push to see if we can align
them better -- they are atm more or less independent, and I am not sure if
that's good or bad... But it's a much broader story, not related to this PR.
Let's revisit later as you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
