shantanukawale-stripe commented on code in PR #23880:
URL: https://github.com/apache/kafka/pull/23880#discussion_r4429956551
##########
storage/src/test/java/org/apache/kafka/storage/internals/log/UnifiedLogTest.java:
##########
@@ -3542,6 +3542,29 @@ public void
testFetchOffsetByTimestampIncludesLeaderEpoch() throws IOException {
log.fetchOffsetByTimestamp(ListOffsetsRequest.LATEST_TIMESTAMP,
Optional.empty()));
}
+ @Test
+ public void testFetchOffsetByTimestampContinuesAfterEmptyEligibleSegment()
throws IOException {
Review Comment:
Thanks, Jun. Renamed it to
`testFetchOffsetByTimestampSearchesNextSegmentWhenMatchIsBelowLogStartOffset`
as suggested. The renamed test and storage checks pass on Java 17. Could you
take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
