1fanwang commented on code in PR #22155: URL: https://github.com/apache/kafka/pull/22155#discussion_r4430076822
########## streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java: ########## @@ -43,6 +43,8 @@ import org.apache.kafka.common.serialization.ByteArraySerializer; import org.apache.kafka.common.serialization.LongSerializer; import org.apache.kafka.common.serialization.Serializer; + +import java.nio.charset.StandardCharsets; Review Comment: Done in https://github.com/apache/kafka/commit/579a27f2ab75d2fe5eae990636a3ce2d2e2f7820. ########## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java: ########## @@ -310,4 +310,5 @@ public String toString(final String indent) { } return sb.toString(); } + Review Comment: Done in https://github.com/apache/kafka/commit/579a27f2ab75d2fe5eae990636a3ce2d2e2f7820. ########## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorRecordContext.java: ########## @@ -107,6 +114,15 @@ public byte[] sourceRawValue() { return sourceRawValue; } + /** + * Returns the snapshot of the original source-record headers if one was captured, + * or falls back to {@link #headers()} if no snapshot was set (e.g., when the context + * was initialized from punctuation or synthetic events). Review Comment: Done in https://github.com/apache/kafka/commit/579a27f2ab75d2fe5eae990636a3ce2d2e2f7820. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
