nileshkumar3 commented on code in PR #23780:
URL: https://github.com/apache/kafka/pull/23780#discussion_r4437136812
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##########
@@ -1738,6 +1748,11 @@ public OffsetResultHolder fetchOffsetByTimestamp(long
targetTimestamp, Optional<
} else if (targetTimestamp ==
ListOffsetsRequest.EARLIEST_PENDING_UPLOAD_TIMESTAMP) {
return
fetchEarliestPendingUploadOffset(remoteOffsetReader);
} else if (targetTimestamp ==
ListOffsetsRequest.MAX_TIMESTAMP) {
+ // A bound below the log end means the segment with
the global max timestamp may hold that
+ // max past the high watermark. Search only the
fetchable prefix. See KAFKA-21204.
+ if (lastFetchableOffset < logEndOffset())
Review Comment:
Removed. MAX_TIMESTAMP now always uses the bounded path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
