nileshkumar3 commented on code in PR #23780:
URL: https://github.com/apache/kafka/pull/23780#discussion_r4437133056
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##########
@@ -1694,6 +1694,16 @@ public List<AbortedTxn> collectAbortedTransactions(long
startOffset, long upperB
* </ul>
*/
public OffsetResultHolder fetchOffsetByTimestamp(long targetTimestamp,
Optional<AsyncOffsetReader> remoteOffsetReader) {
+ return fetchOffsetByTimestamp(targetTimestamp, remoteOffsetReader,
Long.MAX_VALUE);
+ }
+
+ /**
+ * Same as {@link #fetchOffsetByTimestamp(long, Optional)} but ignores
offsets at or after {@code lastFetchableOffset}.
Review Comment:
Clarified it. The bound applies to MAX_TIMESTAMP and to timestamp search in
the local log. Did you mean MAX_TIMESTAMP only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
