chia7712 commented on code in PR #24015:
URL: https://github.com/apache/kafka/pull/24015#discussion_r4450031130
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java:
##########
@@ -1505,7 +1505,15 @@ public Optional<Set<Integer>> partitions(final String
topic,
final Headers headers,
final int numPartitions) {
final Integer partition = value.primaryPartition();
- return partition == null ? Optional.empty() :
Optional.of(Set.of(partition));
+ if (partition == null) {
+ return Optional.empty();
+ }
+ if (partition < 0 || partition >= numPartitions) {
Review Comment:
I’m fine with this guard logic, but would you mind sharing the scenarios
which can produce those invalid values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
