cheeeee commented on PR #24072:
URL: https://github.com/apache/kafka/pull/24072#issuecomment-6619925284
Test notes for 03d0e80fa7 (on 1bc314cf28, base 8aa57006ff), JDK 17.
Unit tests:
* `UnifiedLogTest.testCollectAbortedTransactionsFromStartOffset` fails
with the old lower bound (`expected: <[AbortedTxn(producerId=2, ...)]>
but was: <[AbortedTxn(producerId=1, ...), AbortedTxn(producerId=2,
...)]>`).
*
`LogCleanerTest.testCommittedTombstoneAfterAbortedTransactionBeforeCleaningStart`
fails on the base commit (`expected: <[3, 4, 5, 8]> but was:
<[2, 3, 4, 5, 8]>`).
* `cleanSegments` still collects from the base offset of each segment:
with its start raised to the dirty offset, 8 transaction tests in
`LogCleanerTest` fail (e.g. `testAbortMarkerRemoval`,
`testCleanWithTransactionsSpanningSegments`). With its upper bound set
back to `map.latestOffset() + 1` (before KAFKA-13727),
`testMultiPassSegmentCleaningWithAbortedTransactions` fails.
* `LocalLogTest`, `UnifiedLogTest`, `LogCleanerTest`,
`LogCleanerManagerTest`, `LogCleanerIntegrationTest`: 373 tests pass.
* `./gradlew :storage:test`, run 1 did not complete: 1351 of 1358
tests ran. `TransactionsWithTieredStoreTest.testFailureToFenceEpochWithTV2`
timed out after 60 s, and the test JVM running
`TransactionsTest` exited during `testFencingOnSend`, so 7 of its 24
tests did not run. Alone, the timed-out test passed 3 of 3 times on
this PR and 3 of 3 on 8aa57006ff, and `TransactionsTest` passed 24 of
24 twice on this PR and once on 8aa57006ff. Run 2: all 1358 tests
pass.
End to end, with the `repro.sh` attached to KAFKA-21410 on a build of
03d0e80fa7:
| OS | `p1` (bug) | `p2` (control) |
|---|---|---|
| macOS 26, arm64 | K not returned | K not returned |
| Linux, Ubuntu 24.04 container | K not returned | K not returned |
| OpenBSD 8.0, arm64 (QEMU) | K not returned | K not returned |
In all runs the cleaner passes are `[0, 78644]` and `[78644, 120005]`,
and the first segment holds no record with key K after cleaning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
