junrao commented on code in PR #24072:
URL: https://github.com/apache/kafka/pull/24072#discussion_r4463997597
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java:
##########
@@ -625,10 +625,10 @@ private void collectAbortedTransactions(long startOffset,
long upperBoundOffset,
}
}
- public List<AbortedTxn> collectAbortedTransactions(long logStartOffset,
long baseOffset, long upperBoundOffset) {
- Optional<LogSegment> segmentEntry = segments.floorSegment(baseOffset);
+ public List<AbortedTxn> collectAbortedTransactions(long startOffset, long
upperBoundOffset) {
Review Comment:
Could we add a javadoc? Sth like the following.
```
/**
* Collect the aborted transactions that may have data in [startOffset,
upperBoundOffset): those ending at or after
* startOffset and starting before upperBoundOffset, scanning the
transaction indexes from the segment containing
* startOffset.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
