chia7712 commented on code in PR #24086:
URL: https://github.com/apache/kafka/pull/24086#discussion_r4453651521


##########
server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java:
##########
@@ -570,16 +562,6 @@ public Node getCoordinatorNode() {
         }
 
         protected abstract boolean isBatchable();
-
-        /**
-         * This method can be called by child class objects to register a 
callback
-         * which will be called when the onComplete cb is called on request 
completion.
-         *
-         * @param callback
-         */
-        protected void setOnCompleteCallback(Consumer<ClientResponse> 
callback) {

Review Comment:
   There is another similar pattern setGenerateCallback, but it is used by 
tests. I opened https://issues.apache.org/jira/browse/KAFKA-21420 to track it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to