chia7712 commented on code in PR #23522: URL: https://github.com/apache/kafka/pull/23522#discussion_r4482117333
########## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ########## @@ -26,23 +26,22 @@ import java.util.stream.Collectors; /** - * This class contains the different Kafka versions. - * Right now, we use them for upgrades - users can configure the version of the API brokers will use to communicate between themselves. - * This is only for inter-broker communications - when communicating with clients, the client decides on the API version. + * This enum contains the different Kafka metadata versions. + * These versions are used during upgrades - users can configure which API version brokers use when communicating with each other. Review Comment: This description is out of date as well. The MV also controls the RPC versions to clients. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
