chia7712 commented on code in PR #23522:
URL: https://github.com/apache/kafka/pull/23522#discussion_r4482150675
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -135,16 +134,22 @@ public enum MetadataVersion {
//
// NOTE: MetadataVersions after this point are unstable and may be changed.
- // If users attempt to use an unstable MetadataVersion, they will get an
error unless
- // they have set the configuration unstable.feature.versions.enable=true.
- // Please move this comment when updating the LATEST_PRODUCTION constant.
+ // The latest unstable version serves as the development and testing
version.
+ // Attempts to use an unstable MetadataVersion will fail unless
+ // unstable.feature.versions.enable=true.
+ //
+ // NOTES when updating MetadataVersion:
+ // 1. Keep the default MetadataVersion in @ClusterTest aligned with
+ // MetadataVersion.latestTesting().
+ // 2. Keep at least one unstable MetadataVersion after LATEST_PRODUCTION.
+ // 3. When updating LATEST_PRODUCTION, keep LATEST_STABLE_METADATA_VERSION
in
+ // tests/kafkatest/version.py aligned with it and move this entire
comment
+ // block below the new LATEST_PRODUCTION constant.
Review Comment:
```
move this entire comment block below the MetadataVersion that
LATEST_PRODUCTION points to.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
