clolov commented on code in PR #24077: URL: https://github.com/apache/kafka/pull/24077#discussion_r4455223901
########## tools/src/main/java/org/apache/kafka/tools/consumer/MirrorStateMessageFormatter.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.tools.consumer; + +import org.apache.kafka.common.protocol.ApiMessage; +import org.apache.kafka.coordinator.mirror.MirrorCoordinatorRecordSerde; +import org.apache.kafka.coordinator.mirror.generated.CoordinatorRecordJsonConverters; + +import com.fasterxml.jackson.databind.JsonNode; + +/** + * Formats records from the {@code __mirror_state} topic for the console consumer. + */ +public class MirrorStateMessageFormatter extends CoordinatorRecordMessageFormatter { + public MirrorStateMessageFormatter() { + super(new MirrorCoordinatorRecordSerde()); + } + + @Override + protected boolean isRecordTypeAllowed(short recordType) { + return true; + } + + @Override + protected JsonNode keyAsJson(ApiMessage message) { + return CoordinatorRecordJsonConverters.writeRecordKeyAsJson(message); + } + + @Override + protected JsonNode valueAsJson(ApiMessage message, short version) { Review Comment: Similar comment to https://github.com/apache/kafka/pull/24078#discussion_r4455146952. Could you also ensure that both PRs render the output the same way so that there is consistency between the log dump tool and the console consumer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
