[
https://issues.apache.org/jira/browse/KAFKA-9046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952294#comment-16952294
]
Chris Egerton commented on KAFKA-9046:
--------------------------------------
Although backwards compatibility was broken by these changes and the initial
approach for a bug fix may be to simply revert them, it's likely that these
changes have been picked up by Connect users and that removing support for the
{{"admin."}} prefix in worker config files will likely break things _again_ for
those users and cause confusion. Additionally, with the support for per-connect
admin client config overrides added by KIP-458, it would be best to keep
support for worker-level default admin client configs to match the current
behavior for connector producers and consumers.
As a result, it'd be good if a bug fix for this issue removed the _requirement_
for the {{"admin."}} prefix in worker files but still respected those
configurations if they're present.
One possible approach is to alter the behavior of the Connect worker to
calculate connector admin client configurations by drawing from the following
properties, in ascending order of priority:
# Begin with all top-level worker properties (in order to retain backwards
compatibility with Connect releases unaffected by this issue)
# Then, apply all properties prefixed with {{"admin."}} in the worker file
after removing the prefix (in order to retain the undocumented changes brought
in by the PR for KIP-458)
# Finally, apply all properties prefixed with {{"admin.override."}} in the
connector configuration after removing the prefix (in the fashion dictated by
KIP-458)
> Connect worker configs require undocumented 'admin.' prefix to configure DLQ
> for connectors
> -------------------------------------------------------------------------------------------
>
> Key: KAFKA-9046
> URL: https://issues.apache.org/jira/browse/KAFKA-9046
> Project: Kafka
> Issue Type: Bug
> Components: KafkaConnect
> Affects Versions: 2.3.0, 2.4.0, 2.3.1
> Reporter: Chris Egerton
> Assignee: Chris Egerton
> Priority: Major
>
> The changes for KAFKA-8265 involved [adding a prefix of "admin." to Connect
> worker
> configs|https://github.com/apache/kafka/pull/6624/files#diff-316d2c222b623ee65e8065863bf4b9ceR606]
> that would be used to configure the admin client that's used for connector
> DLQs. However, this was never documented in the [corresponding
> KIP|https://cwiki.apache.org/confluence/display/KAFKA/KIP-458%3A+Connector+Client+Config+Override+Policy]
> and has broken backwards compatibility with prior Connect releases since
> workers without the necessary {{"admin."}}-prefixed properties in their
> configuration files will now fail in some circumstances (e.g., when
> interacting with a secured Kafka cluster that requires authentication from
> all admin clients that interact with it).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
