[
https://issues.apache.org/jira/browse/KAFKA-9046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952386#comment-16952386
]
ASF GitHub Bot commented on KAFKA-9046:
---------------------------------------
C0urante commented on pull request #7525: KAFKA-9046: Use top-level worker
configs for connector admin clients
URL: https://github.com/apache/kafka/pull/7525
[Jira](https://issues.apache.org/jira/browse/KAFKA-9046)
The changes here are meant to find a healthy compromise between the pre- and
post-KIP-458 functionality of Connect workers when configuring admin clients
for use with DLQs. Before KIP-458, admin clients were configured using the
top-level worker configs; after KIP-458, they are configured using worker
configs with a prefix of `admin.` and then optionally overridden by connector
configs with a prefix of `admin.override.`. The behavior proposed here is to
use, in ascending order of precedence, the top-level worker configs, worker
configs prefixed with `admin.`, and connector configs prefixed with
`admin.override.`; essentially, use the pre-KIP-458 behavior by default but
allow it to be overridden by the post-KIP-458 behavior.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Connect worker configs require undocumented 'admin.' prefix to configure DLQ
> for connectors
> -------------------------------------------------------------------------------------------
>
> Key: KAFKA-9046
> URL: https://issues.apache.org/jira/browse/KAFKA-9046
> Project: Kafka
> Issue Type: Bug
> Components: KafkaConnect
> Affects Versions: 2.3.0, 2.4.0, 2.3.1
> Reporter: Chris Egerton
> Assignee: Chris Egerton
> Priority: Major
>
> The changes for KAFKA-8265 involved [adding a prefix of "admin." to Connect
> worker
> configs|https://github.com/apache/kafka/pull/6624/files#diff-316d2c222b623ee65e8065863bf4b9ceR606]
> that would be used to configure the admin client that's used for connector
> DLQs. However, this was never documented in the [corresponding
> KIP|https://cwiki.apache.org/confluence/display/KAFKA/KIP-458%3A+Connector+Client+Config+Override+Policy]
> and has broken backwards compatibility with prior Connect releases since
> workers without the necessary {{"admin."}}-prefixed properties in their
> configuration files will now fail in some circumstances (e.g., when
> interacting with a secured Kafka cluster that requires authentication from
> all admin clients that interact with it).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
