[ 
https://issues.apache.org/jira/browse/KAFKA-8784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048177#comment-17048177
 ] 

Sophie Blee-Goldman commented on KAFKA-8784:
--------------------------------------------

[~sbellapu] we actually can't implement this until we bump the major version, 
as it will break backwards compatibility. You're definitely welcome to pick 
this up once the major version is bumped to 3, but as far as I know we aren't 
planning to release 3.0 any time soon.

> Remove default implementation of RocksDBConfigSetter#close
> ----------------------------------------------------------
>
>                 Key: KAFKA-8784
>                 URL: https://issues.apache.org/jira/browse/KAFKA-8784
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: Sophie Blee-Goldman
>            Priority: Blocker
>             Fix For: 3.0.0
>
>
> In 2.3 we added a new method to RocksDBConfigSetter that will be called when 
> a store is closed to clean up any resources that may have been created in 
> #setConfig. Many large objects such as the block cache might be instantiated 
> in that method, which will leak memory if not closed since they are backed by 
> C++ objects.
> We should consider removing the default implementation to force users to pay 
> attention to whether they may be leaking memory, even if it may be a no-op 
> for many. 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to