kkonstantine commented on a change in pull request #8204:
URL: https://github.com/apache/kafka/pull/8204#discussion_r416866064
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java
##########
@@ -220,6 +220,8 @@ public void stop() {
workerMetricsGroup.close();
connectorStatusMetricsGroup.close();
+
+ workerConfigTransformer.close();
Review comment:
Looking at the initialization of `workerConfigTransformer` I see it
should be made final.
And then I notice that this is the case for
`connectorClientConfigOverridePolicy` and all the class members of
`ConnectorStatusMetricsGroup`. @tombentley do you mind tightening these types
as well?
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfigTransformer.java
##########
@@ -98,4 +101,8 @@ public void onCompletion(Throwable error, Void result) {
HerderRequest request = worker.herder().restartConnector(ttl,
connectorName, cb);
connectorRequests.put(path, request);
}
+
+ public void close() {
Review comment:
should we also change this class to implement `AutoCloseable`?
This can't be used immediately in a try-with-resources clause, but probably
better to signal the existence of this method at the class level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
