kkonstantine commented on a change in pull request #8204:
URL: https://github.com/apache/kafka/pull/8204#discussion_r417416928
##########
File path:
clients/src/test/java/org/apache/kafka/common/config/provider/MockFileConfigProvider.java
##########
@@ -19,11 +19,46 @@
import java.io.IOException;
import java.io.Reader;
import java.io.StringReader;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
public class MockFileConfigProvider extends FileConfigProvider {
+ private static final Map<String, MockFileConfigProvider> INSTANCES =
Collections.synchronizedMap(new HashMap<>());
+ private String id;
+ private boolean closed = false;
+
+ public void configure(Map<String, ?> configs) {
+ Object id = configs.get("testId");
+ if (id == null) {
+ throw new RuntimeException(getClass().getName() + " missing
'testId' config");
+ }
+ if (this.id != null) {
+ throw new RuntimeException(getClass().getName() + " instance was
configured twice");
+ }
+ this.id = id.toString();
+ INSTANCES.put(id.toString(), this);
+ }
+
@Override
protected Reader reader(String path) throws IOException {
return new StringReader("key=testKey\npassword=randomPassword");
}
+
+ @Override
+ public synchronized void close() {
+ closed = true;
+ }
+
+ public static void assertClosed(String id) {
+ MockFileConfigProvider instance = INSTANCES.remove(id);
+ assertNotNull(instance);
+ synchronized (instance) {
Review comment:
Seems `volatile` would works as well in this case. But that's fine for
this test class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
