ableegoldman commented on a change in pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#discussion_r418791000
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -556,14 +548,8 @@ void runLoop() {
while (isRunning() || taskManager.isRebalanceInProgress()) {
try {
runOnce();
- if (assignmentErrorCode.get() ==
AssignorError.REBALANCE_NEEDED.code()) {
- log.info("Detected that the assignor requested a
rebalance. Rejoining the consumer group to " +
- "trigger a new rebalance.");
- assignmentErrorCode.set(AssignorError.NONE.code());
- mainConsumer.enforceRebalance();
- } else if (nextProbingRebalanceMs.get() < time.milliseconds())
{
- log.info("The probing rebalance interval has elapsed since
the last rebalance, triggering a " +
- "rebalance to probe for newly caught-up
clients");
+ if (nextProbingRebalanceMs.get() < time.milliseconds()) {
+ log.info("Triggering the followup rebalance scheduled for
{} ms.", nextProbingRebalanceMs.get());
Review comment:
We lose information here, but now log the reason for the scheduled
rebalance in a (hopefully) more clear way during `onAssignment`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
