ableegoldman commented on a change in pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#discussion_r418792433
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##########
@@ -907,6 +905,17 @@ private void populatePartitionsByHostMaps(final
Map<HostInfo, Set<TopicPartition
minSupportedMetadataVersion,
false,
encodeNextProbingRebalanceTime);
+
+ if (followupRebalanceScheduled) {
+ rebalanceRequired = true;
+ log.debug("Requested client {} to schedule a followup
rebalance", clientId);
+ }
+ }
+
+ if (rebalanceRequired) {
Review comment:
Previously we were doing this logging at the client-level, meaning we
could end up in the confusing situation of logging `Stable rebalance..` for one
client and `Unstable rebalance...` for another, all in the same rebalance. Now
we only log the final result after all client assignments are encoded, and log
which clients actually are scheduling said rebalance at the debug level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
