chia7712 commented on a change in pull request #8605: URL: https://github.com/apache/kafka/pull/8605#discussion_r419105581
########## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ########## @@ -1235,19 +1245,6 @@ private void close(Duration timeout, boolean swallowException) { log.debug("Kafka producer has been closed"); } - private static Map<String, Object> propsToMap(Properties properties) { Review comment: this check is duplicate to https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java#L103 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org