chia7712 commented on a change in pull request #8605:
URL: https://github.com/apache/kafka/pull/8605#discussion_r419180021
##########
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##########
@@ -284,7 +283,8 @@ public KafkaProducer(final Map<String, Object> configs) {
* be called in the producer when the serializer
is passed in directly.
*/
public KafkaProducer(Map<String, Object> configs, Serializer<K>
keySerializer, Serializer<V> valueSerializer) {
- this(configs, keySerializer, valueSerializer, null, null, null,
Time.SYSTEM);
+ this(new ProducerConfig(ProducerConfig.addSerializerToConfig(configs,
keySerializer, valueSerializer)),
Review comment:
Thanks for reviews!
Do you mean that previous approach tried to avoid
‘’’addSerializerToConfig’’’? If so, should we do it for KafkaConsumer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
