hachikuji commented on a change in pull request #8585:
URL: https://github.com/apache/kafka/pull/8585#discussion_r419609984
##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -949,8 +949,11 @@ class ReplicaManager(val config: KafkaConfig,
else
FetchHighWatermark
- // Restrict fetching to leader if request is from follower or from a
client with older version (no ClientMetadata)
- val fetchOnlyFromLeader = isFromFollower || (isFromConsumer &&
clientMetadata.isEmpty)
+ // Restrict fetching to leader if request is from follower or from an
ordinary consumer
+ // with an older version (which is implied by no ClientMetadata)
Review comment:
Yeah, I was debating the latter. It's probably unlikely that this is
used outside of the ReplicaVerificationTest. As far as I know, no one has filed
an issue about it, so maybe we could drop this support. I decided to err on the
side of compatibility, but I could probably be convinced to change my mind.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
