ijuma commented on a change in pull request #8585:
URL: https://github.com/apache/kafka/pull/8585#discussion_r420805481
##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -949,8 +949,11 @@ class ReplicaManager(val config: KafkaConfig,
else
FetchHighWatermark
- // Restrict fetching to leader if request is from follower or from a
client with older version (no ClientMetadata)
- val fetchOnlyFromLeader = isFromFollower || (isFromConsumer &&
clientMetadata.isEmpty)
+ // Restrict fetching to leader if request is from follower or from an
ordinary consumer
+ // with an older version (which is implied by no ClientMetadata)
Review comment:
Can we remove `DebuggingConsumerId` altogether or is there any
functionality that it provides in today's world? If it doesn't provide any
useful functionality now, I would just remove it and it's one less concept to
support and think about. As you said, I don't think anyone actually uses this
outside of the `ReplicaVerificationTool`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
