chia7712 commented on a change in pull request #8663:
URL: https://github.com/apache/kafka/pull/8663#discussion_r424859533
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SinkConnectorConfig.java
##########
@@ -108,6 +132,20 @@ public static boolean hasTopicsRegexConfig(Map<String,
String> props) {
return topicsRegexStr != null && !topicsRegexStr.trim().isEmpty();
}
+ public static boolean hasDlqTopicConfig(Map<String, String> props) {
+ String dqlTopicStr = props.get(DLQ_TOPIC_NAME_CONFIG);
+ return dqlTopicStr != null && !dqlTopicStr.trim().isEmpty();
+ }
+
+ public static List<String> parseTopicsList(Map<String, String> props) {
+ List<String> topics = (List<String>)
ConfigDef.parseType(TOPICS_CONFIG, props.get(TOPICS_CONFIG), Type.LIST);
+ return topics
+ .stream()
+ .filter(topic -> !topic.isEmpty())
+ .distinct()
Review comment:
why not just return a Set instead of List?
```
return topics
.stream()
.filter(topic -> !topic.isEmpty())
.collect(Collectors.toSet());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
