chia7712 commented on a change in pull request #8663:
URL: https://github.com/apache/kafka/pull/8663#discussion_r424860254
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SinkConnectorConfig.java
##########
@@ -96,6 +101,25 @@ public static void validate(Map<String, String> props) {
throw new ConfigException("Must configure one of " +
SinkTask.TOPICS_CONFIG + " or " +
SinkTask.TOPICS_REGEX_CONFIG);
}
+
+ if (hasDlqTopicConfig) {
+ String dlqTopic = props.get(DLQ_TOPIC_NAME_CONFIG).trim();
+ if (hasTopicsConfig) {
+ List<String> topics = parseTopicsList(props);
+ if (topics.contains(dlqTopic)) {
+ throw new ConfigException(DLQ_TOPIC_NAME_CONFIG + " has a
topic name which is already in " +
Review comment:
Should we log the topic name for this exception? For example, ```has a
topic name (xxx) which```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
