mjsax commented on a change in pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#discussion_r426211719
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java
##########
@@ -1393,6 +1409,11 @@ public void shouldPreserveSerdesForOperators() {
assertEquals(((AbstractStream) stream1.through("topic-3",
Produced.with(mySerde, mySerde))).keySerde(), mySerde);
assertEquals(((AbstractStream) stream1.through("topic-3",
Produced.with(mySerde, mySerde))).valueSerde(), mySerde);
+ assertEquals(((AbstractStream) stream1.repartition()).keySerde(),
consumedInternal.keySerde());
+ assertEquals(((AbstractStream) stream1.repartition()).valueSerde(),
consumedInternal.valueSerde());
+ assertEquals(((AbstractStream)
stream1.repartition(Repartitioned.with(mySerde, mySerde))).keySerde(), mySerde);
+ assertEquals(((AbstractStream)
stream1.repartition(Repartitioned.with(mySerde, mySerde))).valueSerde(),
mySerde);
Review comment:
replicating test cases
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java
##########
@@ -1452,6 +1474,24 @@ public void
shouldUseRecordMetadataTimestampExtractorWithThrough() {
assertNull(processorTopology.source("topic-1").getTimestampExtractor());
}
+ @Test
+ public void shouldUseRecordMetadataTimestampExtractorWithRepartition() {
Review comment:
replicating test
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java
##########
@@ -1467,6 +1507,21 @@ public void shouldSendDataThroughTopicUsingProduced() {
assertThat(processorSupplier.theCapturedProcessor().processed,
equalTo(Collections.singletonList(new KeyValueTimestamp<>("a", "b", 0))));
}
+ @Test
+ public void shouldSendDataThroughRepartitionTopicUsingRepartitioned() {
Review comment:
replicating test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
