vvcephei commented on a change in pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#discussion_r426337376
##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java
##########
@@ -846,16 +847,13 @@
* from the auto-generated topic using default serializers, deserializers,
and producer's {@link DefaultPartitioner}.
* The number of partitions is determined based on the upstream topics
partition numbers.
* <p>
- * This operation is similar to {@link #through(String)}, however, Kafka
Streams manages the used topic automatically.
Review comment:
I'd agree with removing it. I guess if you want to preserve it in some
fashion, you could add the opposite statement to the `through()` documentation.
##########
File path:
streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Repartitioned.scala
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.streams.scala.kstream
+
+import org.apache.kafka.common.serialization.Serde
+import org.apache.kafka.streams.kstream.{Repartitioned => RepartitionedJ}
+import org.apache.kafka.streams.processor.StreamPartitioner
+
+object Repartitioned {
+
+ /**
+ * Create a Repartitioned instance with provided keySerde and valueSerde.
+ *
+ * @tparam K key type
+ * @tparam V value type
+ * @param keySerde Serde to use for serializing the key
+ * @param valueSerde Serde to use for serializing the value
+ * @return A new [[Repartitioned]] instance configured with keySerde and
valueSerde
+ * @see KStream#repartition(Repartitioned)
+ */
+ def `with`[K, V](implicit keySerde: Serde[K], valueSerde: Serde[V]):
RepartitionedJ[K, V] =
Review comment:
We'd have to change from `object` to `class` or `case class` (which
would have been my preference to begin with), since `object`s can only have
static members.
Probably, this ship has sailed for now, and we should just keep doing what
the other similar classes are doing. Since we've found so much wackiness in the
Scala API since it was introduced, it might be a good idea to consider
revamping the whole thing from scratch some day.
##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java
##########
@@ -815,9 +815,10 @@
*
* @param topic the topic name
* @return a {@code KStream} that contains the exact same (and potentially
repartitioned) records as this {@code KStream}
- * @see #repartition()
- * @see #repartition(Repartitioned)
+ * @deprecated used {@link #repartition()} instead
Review comment:
It's a little nice for future reference when we also say when it became
deprecated, such as "since 2.6".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
