vvcephei commented on a change in pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#discussion_r427621177
##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java
##########
@@ -815,9 +815,10 @@
*
* @param topic the topic name
* @return a {@code KStream} that contains the exact same (and potentially
repartitioned) records as this {@code KStream}
- * @see #repartition()
- * @see #repartition(Repartitioned)
+ * @deprecated used {@link #repartition()} instead
Review comment:
For one thing, it's nice for _us_, so we can easily tell when it's been
deprecated "long enough" to remove. I can recall trudging through git history
in the past to figure this out.
For users, maybe you don't care, but I personally find it nice when my
libraries do this for me. It's just good bookkeeping, and it gives me some
confidence that the maintainers are doing proper, tidy maintenance.
If it provides a "third party" supporting opinion, the Scala language
designers thought this was important enough to build it in as a separate field
of the "deprecated" annotation:
https://docs.scala-lang.org/tour/annotations.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
