hachikuji commented on a change in pull request #8702:
URL: https://github.com/apache/kafka/pull/8702#discussion_r429327443
##########
File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
##########
@@ -502,14 +502,8 @@ private void doSend(ClientRequest clientRequest, boolean
isInternalRequest, long
String destination = clientRequest.destination();
RequestHeader header = clientRequest.makeHeader(request.version());
if (log.isDebugEnabled()) {
- int latestClientVersion = clientRequest.apiKey().latestVersion();
- if (header.apiVersion() == latestClientVersion) {
- log.trace("Sending {} {} with correlation id {} to node {}",
clientRequest.apiKey(), request,
Review comment:
Given that we have to work with all client versions, it's just as common
for the client not to match the broker version, so it's not really useful for
the behavior to be different when they do match.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
