hachikuji commented on a change in pull request #8702:
URL: https://github.com/apache/kafka/pull/8702#discussion_r429328416
##########
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java
##########
@@ -312,8 +313,27 @@ public void testJoinGroupRequestTimeout() {
mockTime.sleep(REQUEST_TIMEOUT_MS + 1);
assertFalse(consumerClient.poll(future, mockTime.timer(0)));
- mockTime.sleep(REBALANCE_TIMEOUT_MS - REQUEST_TIMEOUT_MS + 5000);
+ mockTime.sleep(REBALANCE_TIMEOUT_MS - REQUEST_TIMEOUT_MS +
AbstractCoordinator.JOIN_GROUP_TIMEOUT_LAPSE);
assertTrue(consumerClient.poll(future, mockTime.timer(0)));
+ assertTrue(future.exception() instanceof DisconnectException);
+ }
+
+ @Test
+ public void
testJoinGroupRequestTimeoutLowerBoundedByDefaultRequestTimeout() {
+ int rebalanceTimeoutMs = REQUEST_TIMEOUT_MS - 10000;
+ setupCoordinator(RETRY_BACKOFF_MS, rebalanceTimeoutMs,
Optional.empty());
+ mockClient.prepareResponse(groupCoordinatorResponse(node,
Errors.NONE));
+ coordinator.ensureCoordinatorReady(mockTime.timer(0));
+
+ RequestFuture<ByteBuffer> future = coordinator.sendJoinGroupRequest();
+
+ long expectedRequestDeadline = mockTime.milliseconds() +
REQUEST_TIMEOUT_MS;
+ mockTime.sleep(rebalanceTimeoutMs +
AbstractCoordinator.JOIN_GROUP_TIMEOUT_LAPSE + 1);
+ assertFalse(consumerClient.poll(future, mockTime.timer(0)));
+
+ mockTime.sleep(expectedRequestDeadline - mockTime.milliseconds() + 1);
Review comment:
We need to take into account the time that has already passed. I was a
little annoyed at having to write `REQUEST_TIMEOUT - rebalanceTimeoutMs -
AbstractCoordinator.JOIN_GROUP_TIMEOUT_LAPSE`. A bit annoying either way I
guess.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
