feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429504532
##########
File path:
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##########
@@ -2411,6 +2429,57 @@ public void testRemoveMembersFromGroup() throws
Exception {
assertNull(noErrorResult.all().get());
assertNull(noErrorResult.memberResult(memberOne).get());
assertNull(noErrorResult.memberResult(memberTwo).get());
+
+ // Test the "removeAll" scenario
+ TopicPartition myTopicPartition0 = new TopicPartition("my_topic",
0);
+ TopicPartition myTopicPartition1 = new TopicPartition("my_topic",
1);
+ TopicPartition myTopicPartition2 = new TopicPartition("my_topic",
2);
+
+ final List<TopicPartition> topicPartitions = new ArrayList<>();
+ topicPartitions.add(0, myTopicPartition0);
+ topicPartitions.add(1, myTopicPartition1);
+ topicPartitions.add(2, myTopicPartition2);
+
+ // construct the DescribeGroupsResponse
+ DescribeGroupsResponseData data =
prepareDescribeGroupsResponseData(groupId, Arrays.asList(instanceOne,
instanceTwo), topicPartitions);
+
+ // Return with partial failure for "removeAll" scenario
+ // 1 prepare response for AdminClient.describeConsumerGroups
+
env.kafkaClient().prepareResponse(prepareFindCoordinatorResponse(Errors.NONE,
env.cluster().controller()));
+ env.kafkaClient().prepareResponse(new
DescribeGroupsResponse(data));
+
+ // 2 KafkaAdminClient encounter partial failure when trying to
delete all members
+
env.kafkaClient().prepareResponse(prepareFindCoordinatorResponse(Errors.NONE,
env.cluster().controller()));
+ env.kafkaClient().prepareResponse(new LeaveGroupResponse(
+ new
LeaveGroupResponseData().setErrorCode(Errors.NONE.code()).setMembers(
+ Arrays.asList(responseOne, responseTwo))
+ ));
+ final RemoveMembersFromConsumerGroupResult partialFailureResults =
env.adminClient().removeMembersFromConsumerGroup(
+ groupId,
+ new RemoveMembersFromConsumerGroupOptions()
+ );
+ ExecutionException exception =
assertThrows(ExecutionException.class, () -> partialFailureResults.all().get());
Review comment:
No existing help method to assert the cause of exception throw by
`all()`. Also think it's more straight forward in this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
