feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429276600
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupResult.java
##########
@@ -51,9 +52,21 @@
if (throwable != null) {
result.completeExceptionally(throwable);
} else {
- for (MemberToRemove memberToRemove : memberInfos) {
- if (maybeCompleteExceptionally(memberErrors,
memberToRemove.toMemberIdentity(), result)) {
- return;
+ if (removeAll()) {
+ for (Map.Entry<MemberIdentity, Errors> entry:
memberErrors.entrySet()) {
+ Exception exception = entry.getValue().exception();
+ if (exception != null) {
+ Throwable ex = new KafkaException("Encounter
exception when trying to remove: "
Review comment:
Wrap to let the failed member info available for caller like
`StreamsResetter`. Only capture the first found member error like in the non
`removeAll` scenario.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
